Re: [PATCH v3.5] dw_dmac: return proper residue value

From: Viresh Kumar
Date: Fri Jan 25 2013 - 04:30:08 EST


On Fri, Jan 25, 2013 at 2:49 PM, Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Fri, Jan 25, 2013 at 11:07 AM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>> Who is going to right on ctlhi/lo?

Ahh, my English :( (/s/right/write)

> dwc_do_single_block()
>
>> we write to ctlhi/lo only when we program new
>> transfer. and that is not going to happen while we are in middle of a transfer.
>
> We have got a tasklet running inside tx_status call. Isn't possible?
> tasklet runs scan_descriptors, that continues transfer in soft LLP mode.

But we have just executed scan_descriptor() before this function and it doesn't
look possible that transfer wasn't over then and inbetween these calls we got an
interrupt, scheduled an tasklet and called dwc_do_single_block() :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/