Re: [PATCH] regulator: lp8755: Use LP8755_BUCK_MAX instead of magic number

[daniel jeong]

On Jan 26, 2013, at 2:19 PM, Axel Lin <axel.lin@xxxxxxxxxx> wrote:

> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
> ---
> drivers/regulator/lp8755.c |    6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/regulator/lp8755.c b/drivers/regulator/lp8755.c
> index 8b1ce0f..f0f6ea0 100644
> --- a/drivers/regulator/lp8755.c
> +++ b/drivers/regulator/lp8755.c
> @@ -373,7 +373,7 @@ static irqreturn_t lp8755_irq_handler(int irq, void *data)
> 		goto err_i2c;
> 
> 	/* sent power fault detection event to specific regulator */
> -	for (icnt = 0; icnt < 6; icnt++)
> +	for (icnt = 0; icnt < LP8755_BUCK_MAX; icnt++)
> 		if ((flag0 & (0x4 << icnt))
> 		    && (pchip->irqmask & (0x04 << icnt))
> 		    && (pchip->rdev[icnt] != NULL))
> @@ -508,7 +508,7 @@ err_irq:
> 
> err_regulator:
> 	/* output disable */
> -	for (icnt = 0; icnt < 0x06; icnt++)
> +	for (icnt = 0; icnt < LP8755_BUCK_MAX; icnt++)
> 		lp8755_write(pchip, icnt, 0x00);
> 
> 	return ret;
> @@ -522,7 +522,7 @@ static int lp8755_remove(struct i2c_client *client)
> 	for (icnt = 0; icnt < mphase_buck[pchip->mphase].nreg; icnt++)
> 		regulator_unregister(pchip->rdev[icnt]);
> 
> -	for (icnt = 0; icnt < 0x06; icnt++)
> +	for (icnt = 0; icnt < LP8755_BUCK_MAX; icnt++)
> 		lp8755_write(pchip, icnt, 0x00);
> 
> 	if (pchip->irq != 0)
> -- 
> 1.7.9.5
> 
> 
> 
Yes you're right!
Thank you Axel. 
Daniel.--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/