Re: [PATCH 04/12] perf, x86: Support the TSX intx/intx_cp qualifiersv2

[Ingo Molnar]

* Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> On Sat, Jan 26, 2013 at 12:54:02PM +0100, Ingo Molnar wrote:
> > 
> > * Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> > 
> > > From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > > 
> > > Implement the TSX transaction and checkpointed transaction 
> > > qualifiers for Haswell. This allows e.g. to profile the number 
> > > of cycles in transactions.
> > 
> > The changelog should explain why this is a basic feature 
> > that is a must-have to have basic perf support. (i.e. 
> > default 'perf record', 'perf report', 'perf stat' and 'perf 
> > top' works and is meaningful.)
> 
> The patch is not needed for primitive cycle sampling only.

So please re-send a truly minimal hw-enabling series first, as 
requested - a minimal series that enables most of the everyday 
usecases.

> These qualifiers are a fundamental feature for any TSX tuning.

Any new, Haswell-specific profiling features should obviously be 
in a second (or third) series of patches.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/