Re: [PATCH 23/26] mfd: ab8500-pwm: Enable support for AB8505 PWMLEDblink

[Lee Jones]

On Mon, 28 Jan 2013, Samuel Ortiz wrote:

> Hi Lee,
> 
> On Tue, Jan 15, 2013 at 12:56:03PM +0000, Lee Jones wrote:
> > From: Naga Radhesh <naga.radheshy@xxxxxxxxxxxxxx>
> > 
> > Enable support for PWM OUT LED blinking for AB8505. Instead of
> > having 3 pwm instances from ab8500 core file add it as platform data.
> > 
> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > Signed-off-by: Naga Radhesh <naga.radheshy@xxxxxxxxxxxxxx>
> > Reviewed-by: Arun MURTHY <arun.murthy@xxxxxxxxxxxxxx>
> > Reviewed-by: Srinidhi KASAGAR <srinidhi.kasagar@xxxxxxxxxxxxxx>
> > ---
> >  drivers/mfd/ab8500-core.c          |   10 --
> >  drivers/misc/ab8500-pwm.c          |  282 ++++++++++++++++++++++++++++++++++++
> >  include/linux/mfd/ab8500/pwmleds.h |   20 +++
> >  include/linux/mfd/abx500/ab8500.h  |    2 +
> >  4 files changed, 304 insertions(+), 10 deletions(-)
> >  create mode 100644 drivers/misc/ab8500-pwm.c
> This pretty much looks like the already existing and PWM API compliant
> drivers/pwm/ab8500-pwm.c. What's the point here ?

This patch pre-dates the new PWM interface.

It's probably the same thing. I'll look into it.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/