Re: [RFC/PATCH] perf x86: Add off-core event constraints forSandy/IvyBridge micro architecture

[Stephane Eranian]

On Sun, Jan 27, 2013 at 6:33 PM, Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> hi,
> I was looking at the offcore stuff and it looks like we might
> be missing some constraints for offcore response events on
> Sandy/IvyBridge.
>
> The table 18.8.5 (Off-core Response Performance Monitoring)
> in Intel SDM states PMC0 for 0xb7 and PMC3 for 0xbb, but
> there's no other explanation or related description.
>
> I can't say/ack if the counters looks bad or right with or
> without the patch so far.. so just curious ;-)
>
Those are artificial constraints which should not be there.
Remember that offcore_rsp uses an extra MSR which has
to be shared by all the counters on the PMU. So a way to
handle the sharing of that extra MSR is to impose an
artificial constraint on the event itself. If it can only run
on one counter, then you get the management of the
extra MSR for free, i.e., only one event gets it.

In perf_events, we use a more sophisticated dynamic scheme
which does not use this artificial constraint. We can measure
the event multiple times and share the extra MSR if possible
(same value). Why multiple times you might ask? For instance,
with different priv levels.


Hope this helps.

> ---
> The Intel SDM (18.8.5 Off-core Response Performance Monitoring)
> states the off-core events MSR_OFFCORE_RSP_0/MSR_OFFCORE_RSP_03
> to be defined only for PMC0/PMC3 respectively.
>
> Adding related constraints.
>
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Cc: Corey Ashford <cjashfor@xxxxxxxxxxxxxxxxxx>
> Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Cc: Paul Mackerras <paulus@xxxxxxxxx>
> Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Cc: Stephane Eranian <eranian@xxxxxxxxxx>
> ---
>  arch/x86/kernel/cpu/perf_event_intel.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c
> index 5dc54fc..d1f240f 100644
> --- a/arch/x86/kernel/cpu/perf_event_intel.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel.c
> @@ -105,6 +105,8 @@ static struct event_constraint intel_snb_event_constraints[] __read_mostly =
>         INTEL_EVENT_CONSTRAINT(0x48, 0x4), /* L1D_PEND_MISS.PENDING */
>         INTEL_UEVENT_CONSTRAINT(0x01c0, 0x2), /* INST_RETIRED.PREC_DIST */
>         INTEL_EVENT_CONSTRAINT(0xcd, 0x8), /* MEM_TRANS_RETIRED.LOAD_LATENCY */
> +       INTEL_EVENT_CONSTRAINT(0xb7, 0x1), /* MSR_OFFCORE_RSP_0 - PMC0 only*/
> +       INTEL_EVENT_CONSTRAINT(0xbb, 0x8), /* MSR_OFFCORE_RSP_1 - PMC3 only*/
>         EVENT_CONSTRAINT_END
>  };
>
> --
> 1.7.11.7
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/