Re: [PATCH 3/11] ksm: trivial tidyups

From: Andrew Morton
Date: Mon Jan 28 2013 - 18:11:05 EST


On Fri, 25 Jan 2013 17:58:11 -0800 (PST)
Hugh Dickins <hughd@xxxxxxxxxx> wrote:

> +#ifdef CONFIG_NUMA
> +#define NUMA(x) (x)
> +#define DO_NUMA(x) (x)

Did we consider

#define DO_NUMA do { (x) } while (0)

?

That could avoid some nasty config-dependent compilation issues.

> +#else
> +#define NUMA(x) (0)
> +#define DO_NUMA(x) do { } while (0)
> +#endif
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/