Re: [GIT PULL] cputime: Full dynticks task/cputime accounting v7

[Steven Rostedt]

On Mon, 2013-01-28 at 20:03 +0100, Frederic Weisbecker wrote:
> Ingo,
> 
> Please pull the new full dynticks cputime accounting code that
> can be found at:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> 	tags/full-dynticks-cputime-for-mingo
> 
> My last concern is the dependency on CONFIG_64BIT. We rely on cputime_t
> being u64 for reasonable nanosec granularity implementation. And therefore
> we need a single instruction fetch to read kernel cpustat for atomicity
> requirement against concurrent incrementation, which only 64 bit archs
> can provide.
> 
> It's probably no big deal to solve this issue. What we need is simply some
> atomic accessors.
> 
> There is just no emergency though as this new option depends on the context
> tracking subsystem that only x86-64 (and soon ppc64) implements yet. And
> this set is complex enough already. I think we can deal with that later.

I've ran these through some basic tests and I don't see any issues. But
why did you drop the 'comment' patch that you had in v6?

Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/