Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16 with generic iowrite(read)8/16(be)

From: Arnd Bergmann
Date: Tue Jan 29 2013 - 11:28:40 EST


On Tuesday 29 January 2013, Alexey Brodkin wrote:
> in(out)_8/in(out)_be16/in(out)_le16 are very powerpc/microblaze
> specific. To enable use of Xilinx System ACE driver build for other
> architectures (for example it's possible to use it on Xilinx ml-509
> board with ARC700 in FPGA) we need to use generic implementation of
> accessors.
>
> Current implementation was successfully built with Sourcery G++ Lite
> 2011.03-39 for Power EABI (ppc44x_defconfig).
>
> Signed-off-by: Alexey Brodkin <abrodkin@xxxxxxxxxxxx>

Is this driver used on powerpc64 as well, or just on microblaze
and/or 32 bit powerpc?

On 64 bit powerpc, ioread involves extra overhead because it
goes through the PCI error handling implementation, so we should
keep using in_le() there.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/