Re: [PATCH] drivers/block/xsysace - replace in(out)_8/in(out)_be16/in(out)_le16with generic iowrite(read)8/16(be)

[Michal Simek]

2013/1/30 Alexey Brodkin <Alexey.Brodkin@xxxxxxxxxxxx>:
> On 01/29/2013 08:27 PM, Arnd Bergmann wrote:
>>
>> On Tuesday 29 January 2013, Alexey Brodkin wrote:
>>>
>>> in(out)_8/in(out)_be16/in(out)_le16 are very powerpc/microblaze
>>> specific. To enable use of Xilinx System ACE driver build for other
>>> architectures (for example it's possible to use it on Xilinx ml-509
>>> board with ARC700 in FPGA) we need to use generic implementation of
>>> accessors.
>>>
>>> Current implementation was successfully built with Sourcery G++ Lite
>>> 2011.03-39 for Power EABI (ppc44x_defconfig).
>>>
>>> Signed-off-by: Alexey Brodkin <abrodkin@xxxxxxxxxxxx>
>>
>>
>> Is this driver used on powerpc64 as well, or just on microblaze
>> and/or 32 bit powerpc?
>>
>> On 64 bit powerpc, ioread involves extra overhead because it
>> goes through the PCI error handling implementation, so we should
>> keep using in_le() there.
>>
>>         Arnd
>>
>
> Personally I have no idea about usage of the named device on powerpc64.
> Wondering if anybody may comment on this?
>
> My only intention was to make the driver portable.
> Do you think if there's another generic alternative for originally used
> accessors?
>
> For example will it be better with "readb/readw/writeb/writew"?

This driver is used on ppc32, microblaze little and big endian
and probably could be used on arm le.

Not sure if we can find out proper IO function which we should use.

btw: I will have to support all these combinations for uartlite, xilinx_spi,
gpio and others xilinx IPs.

Thanks,
Michal




-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/