Re: [PATCH 07/12] perf, x86: Avoid checkpointed counters causing excessive TSX aborts v3

From: Andi Kleen
Date: Wed Jan 30 2013 - 15:59:14 EST


> That's a very low sampling rate, yet I think it would be rejected by your code.

You mean allowed?

> But if I come in with frequency 0x7fffffff+1, then that's a very high
> frequency, thus
> small period, I would pass the test. So I think you need to reinforce the test
> for freq=1.

I'm aware that there are some configs that can slip through, but there's
no other choice if we still allow guest perf stat. The cutoff is
somewhat arbitary.

It's not a correctness problem, just things can be unexpectedly slower
and you may see unexpected NMI messages.

-Andi
--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/