Re: [PATCH V3] drm_crtc: check if fb_create return NULL

[Daniel Vetter]

On Thu, Jan 31, 2013 at 1:55 AM, Su, Xuemin <xuemin.su@xxxxxxxxx> wrote:
> -----Original Message-----
> From: Jani Nikula [mailto:jani.nikula@xxxxxxxxxxxxxxx]
> Sent: Thursday, January 24, 2013 5:05 PM
> To: Su, Xuemin
> Cc: airlied@xxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; yanmin_zhang@xxxxxxxxxxxxxxx; He, Bo
> Subject: Re: [PATCH V3] drm_crtc: check if fb_create return NULL
>
>>Ah, sorry, never mind, I missed Daniel's comment. The benefit of the
>>BUG_ON() is making it clear what's expected of the drivers.
>
>>Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>
> Do you think this patch is still needed?
> Currently I fix a buggy function radeon_user_framebuffer_create() which returns NULL and patch is added to 3.7-stable tree.
> Do you think it's also needed to do something in drm_mode_addfb()?

Imo it's still useful, just to document the assumptions of the interface. Dave?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/