Re: [PATCH] x86, numa: Use __pa_nodebug instead

From: Borislav Petkov
Date: Thu Jan 31 2013 - 04:49:32 EST


On Mon, Jan 28, 2013 at 11:16:24AM -0800, Dave Hansen wrote:
> On 01/26/2013 04:18 PM, Borislav Petkov wrote:
> > From: Borislav Petkov <bp@xxxxxxx>
> >
> > ... and fix the following warning:
> >
> > arch/x86/mm/numa.c: In function âsetup_node_dataâ:
> > arch/x86/mm/numa.c:222:3: warning: passing argument 1 of â__phys_addr_nodebugâ makes integer from pointer without a cast [enabled by default]
> > In file included from /home/boris/w/kernel/linux-2.6/arch/x86/include/asm/page.h:11:0,
> > from /home/boris/w/kernel/linux-2.6/arch/x86/include/asm/thread_info.h:11,
> > from include/linux/thread_info.h:54,
> > from include/linux/preempt.h:9,
> > from include/linux/spinlock.h:50,
> > from include/linux/mmzone.h:7,
> > from include/linux/gfp.h:4,
> > from include/linux/mm.h:8,
> > from arch/x86/mm/numa.c:3:
> > /home/boris/w/kernel/linux-2.6/arch/x86/include/asm/page_64.h:12:29: note: expected âlong unsigned intâ but argument is of type âvoid *â
> >
> > Signed-off-by: Borislav Petkov <bp@xxxxxxx>
> > Cc: Dave Hansen <dave@xxxxxxxxxxxxxxxxxx>
>
> I was just about to send out a patch for it and came up with the same fix.
>
> Acked-by: Dave Hansen <dave@xxxxxxxxxxxxxxxxxx>

This still triggers on tip:x86/mm.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/