Re: [PATCH v2 1/2] Fix wrong EOF compare

From: Rob Landley
Date: Thu Jan 31 2013 - 13:51:50 EST


On 01/13/2013 12:15:41 PM, Randy Dunlap wrote:
On 01/13/13 03:44, Rob Landley wrote:
> On 01/11/2013 08:21:55 AM, Michal Nazarewicz wrote:
>> On Fri, Jan 11 2013, Minchan Kim <minchan@xxxxxxxxxx> wrote:
>> > The C standards allows the character type char to be singed or unsinged,
>> > depending on the platform and compiler. Most of systems uses signed char,
>> > but those based on PowerPC and ARM processors typically use unsigned char.
>> > This can lead to unexpected results when the variable is used to compare
>> > with EOF(-1). It happens my ARM system and this patch fixes it.
>> >
>> > Cc: Mel Gorman <mgorman@xxxxxxx>
>> > Cc: Andy Whitcroft <apw@xxxxxxxxxxxx>
>> > Cc: Alexander Nyberg <alexn@xxxxxxxxx>
>> > Cc: Michal Nazarewicz <mina86@xxxxxxxxxx>
>>
>> Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx>
>>
>> > Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>> > Signed-off-by: Minchan Kim <minchan@xxxxxxxxxx>
>> > ---
>> > Documentation/page_owner.c | 7 ++++---
>> > 1 file changed, 4 insertions(+), 3 deletions(-)
>
> My kernel tree doesn't have Documentation/page_owner.c, where do I find this file?

It's in -mm (mmotm), so Andrew can/should merge this ...

Actually, why is a .c source file at the top level of Documentation?

Example code is nice and all, but this name doesn't say "test" or "example" or anything like that, and isn't collated into a subdirectory with any kind of explanatory files like all the others are.

Rob--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/