Re: [PATCH 2/7] liblock: public headers for mutex implementation

[Ingo Molnar]

* Sasha Levin <sasha.levin@xxxxxxxxxx> wrote:

> These headers provide the same API as their pthread mutex counterparts.
> 
> The design here is to allow to easily switch to liblock lock validation
> just by adding a "liblock_" to pthread_mutex_*() calls, which means that
> it's easy to integrate liblock into existing codebases.

I'd suggest to name the user-space counterpart 'liblockdep', to 
make it clear that this is user-space lockdep.

Regarding pthread_mutex_t checking, I think what we *really* 
want is a wrapper that can be activated via:

#define __USE_LIBLOCKDEP

And which then takes over the pthread primitives via:

  #define pthread_mutex_lock liblockdep_pthread_mutex_lock

or so.

That way the source code only needs a __USE_LIBLOCKDEP in one or 
two key places and checking is activated.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/