Re: [PATCH] init: fix name of root device in /proc/mounts

[H. Peter Anvin]

On 02/01/2013 09:14 AM, William Hubbs wrote:
> On Thu, Jan 31, 2013 at 03:22:09PM -0800, H. Peter Anvin wrote:
> > On 01/31/2013 02:51 PM, William Hubbs wrote:
> > > On a system that does not use an initramfs, /dev/root was always
> > > listed in /proc/mounts. This breaks software which scans /proc/mounts to
> > > determine which file systems are mounted since /dev/root is not a valid
> > > device name.
> > >
> > > This changes that processing so that "/dev/root" is only added to
> > > /proc/mounts if a root device is not specified with the root= option on
> > > the kernel command line.
> > >
> > > Signed-off-by: William Hubbs <w.d.hubbs@xxxxxxxxx>
> >
> > Let me also point out that most of the time, the kernel actually has a
> > udev device name for an actual device...
>
> I'm not sure what you mean. If you mean /dev/root is not an actual
> device and should not be listed in /proc/mounts, that is correct and
> that is why I am proposing this patch.

What I meant is that even if you *don't* specify a root= device the 
modern kernel will generally have a usable name.

	-hpa


--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/