Re: [RFC][PATCH v8 2/3] trace,x86: add x86 irq vector tracepoints

From: Steven Rostedt
Date: Fri Feb 01 2013 - 17:15:53 EST


On Fri, 2013-02-01 at 21:06 +0000, Seiji Aguchi wrote:
> > > +#include <asm/hw_irq.h>
> > > +#include <asm/desc.h>
> > > +
> > > +static struct desc_ptr trace_idt_descr = { NR_VECTORS * 16 - 1,
> > > + (unsigned long) trace_idt_table };
> > > +
> > > +#ifndef CONFIG_X86_64
> > > +gate_desc trace_idt_table[NR_VECTORS] __page_aligned_data
> > > + = { { { { 0, 0 } } }, };
> > > +#endif
> > > +
> > > +static struct desc_ptr orig_idt_descr[NR_CPUS];
> >
> > BTW, this should be:
> >
> > static DEFINE_PER_CPU(struct desc_ptr, orig_idt_descr);
> >
> > And look at the patch I made about the NMI/DEBUG trap handling to see how to use it.
>
> Thanks.
> I'm looking at your patch right now and will update my patch.

Also, don't forget to add the mutex protection that I suggested in
another email.

Thanks,

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/