Re: [ 06/89] powerpc/book3e: Disable interrupt afterpreempt_schedule_irq

From: Ben Hutchings
Date: Sun Feb 03 2013 - 08:01:26 EST


On Fri, 2013-02-01 at 14:07 +0100, Greg Kroah-Hartman wrote:
> 3.7-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Tiejun Chen <tiejun.chen@xxxxxxxxxxxxx>
>
> commit 572177d7c77db1981ba2563e01478126482c43bc upstream.
>
> In preempt case current arch_local_irq_restore() from
> preempt_schedule_irq() may enable hard interrupt but we really
> should disable interrupts when we return from the interrupt,
> and so that we don't get interrupted after loading SRR0/1.
>
> Signed-off-by: Tiejun Chen <tiejun.chen@xxxxxxxxxxxxx>
> Signed-off-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
[...]

Is this needed for any earlier kernel versions?

Ben.

--
Ben Hutchings
Everything should be made as simple as possible, but not simpler.
- Albert Einstein

Attachment: signature.asc
Description: This is a digitally signed message part