Re: [PATCHv2 2/2] sched/rt: add a tuning knob to allow changingSCHED_RR timeslice

From: Ingo Molnar
Date: Sun Feb 03 2013 - 13:57:27 EST



* Ingo Molnar <mingo@xxxxxxxxxx> wrote:

> The first patch looks good, I've applied it.

I've skipped this one after all, as it sometimes generates:

include/linux/sched/sysctl.h:108:41: warning: âstruct signal_structâ declared inside parameter list [enabled by default]

Sometimes doesn't built kernel/sched/auto_group.c. So those bits
probably want to move into a separate sched/auto_group.h header
or so.

But, more fundamentally, I think sched.h should not include the
new sched/sysctl.h file. The whole point is to move out bits
from sched.h and decouple them from sched.h - to shrink sched.h
in the long run.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/