Re: [PATCH 4/5] iommu: Add domain window handling functions

[Stuart Yoder]

On Mon, Feb 4, 2013 at 12:56 PM, Joerg Roedel <joro@xxxxxxxxxx> wrote:
> On Mon, Feb 04, 2013 at 12:10:51PM -0600, Stuart Yoder wrote:
>> On Mon, Feb 4, 2013 at 7:18 AM, Joerg Roedel <joro@xxxxxxxxxx> wrote:
>> > +static inline int iommu_domain_window_enable(struct iommu_domain *domain,
>> > +                                            u32 wnd_nr, phys_addr_t paddr,
>> > +                                            size_t size)
>> > +{
>> > +       return -ENODEV;
>> > +}
>> > +
>> > +static inline void iommu_domain_window_disable(struct iommu_domain *domain,
>> > +                                              u32 wnd_nr)
>> > +{
>> > +}
>> > +
>> >  static inline phys_addr_t iommu_iova_to_phys(struct iommu_domain *domain,
>> >                                              unsigned long iova)
>> >  {
>>
>> This API looks workable.   The one change we need is that the size argument in
>> the enable API needs to be 64 bits.   Our window sizes can exceed 4GB.
>
> Okay. So if your architecture supports sizes over 2^32 then size_t
> probably is already 64bits, right?

No, on a 32-bit platform size_t would generally be 32-bits.  But the PAMU
is independent of that.   I think we should just make it a u64.

Stuart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/