RE: [PATCH v3 3/3] QEMU-AER: Qemu changes to support AER forVFIO-PCI devices

[Pandarathil, Vijaymohan R]

> -----Original Message-----
> From: Gleb Natapov [mailto:gleb@xxxxxxxxxx]
> Sent: Tuesday, February 05, 2013 12:05 AM
> To: Blue Swirl
> Cc: Pandarathil, Vijaymohan R; Alex Williamson; Bjorn Helgaas; Ortiz, Lance
> E; kvm@xxxxxxxxxxxxxxx; qemu-devel@xxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 3/3] QEMU-AER: Qemu changes to support AER for VFIO-
> PCI devices
> 
> On Sun, Feb 03, 2013 at 04:36:11PM +0000, Blue Swirl wrote:
> > On Sun, Feb 3, 2013 at 2:10 PM, Pandarathil, Vijaymohan R
> > <vijaymohan.pandarathil@xxxxxx> wrote:
> > >         - Create eventfd per vfio device assigned to a guest and
> register an
> > >           event handler
> > >
> > >         - This fd is passed to the vfio_pci driver through the SET_IRQ
> ioctl
> > >
> > >         - When the device encounters an error, the eventfd is signalled
> > >           and the qemu eventfd handler gets invoked.
> > >
> > >         - In the handler decide what action to take. Current action
> taken
> > >           is to terminate the guest.
> >
> > Usually this is not OK, but I guess this is not guest triggerable.
> >
> Still not OK. Why not stop a guest with appropriate stop reason?

The thinking was that since this is a hardware error, we would want to stop the guest at the earliest. The hw_error() routine which aborts the qemu process was suggested by Alex and that seemed appropriate. Earlier I was using qemu_system_shutdown_request().  Any suggestions ?

Thanks

Vijay
> 
> --
> 			Gleb.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/