Re: [PATCH 06/30] usb: phy: nop: use new PHY API to register PHY

From: Felipe Balbi
Date: Tue Feb 05 2013 - 04:24:33 EST


On Mon, Jan 28, 2013 at 01:30:07PM +0200, Roger Quadros wrote:
> We would need to support multiple PHYs of the same type
> so use the new PHY API usb_add_phy_dev() to register the PHY.
>
> Signed-off-by: Roger Quadros <rogerq@xxxxxx>

Acked-by: Felipe Balbi <balbi@xxxxxx>

> ---
> drivers/usb/otg/nop-usb-xceiv.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/otg/nop-usb-xceiv.c b/drivers/usb/otg/nop-usb-xceiv.c
> index 3060ed0..ac027a1 100644
> --- a/drivers/usb/otg/nop-usb-xceiv.c
> +++ b/drivers/usb/otg/nop-usb-xceiv.c
> @@ -197,12 +197,13 @@ static int nop_usb_xceiv_probe(struct platform_device *pdev)
> nop->phy.init = nop_init;
> nop->phy.shutdown = nop_shutdown;
> nop->phy.state = OTG_STATE_UNDEFINED;
> + nop->phy.type = type;
>
> nop->phy.otg->phy = &nop->phy;
> nop->phy.otg->set_host = nop_set_host;
> nop->phy.otg->set_peripheral = nop_set_peripheral;
>
> - err = usb_add_phy(&nop->phy, type);
> + err = usb_add_phy_dev(&nop->phy);
> if (err) {
> dev_err(&pdev->dev, "can't register transceiver, err: %d\n",
> err);
> --
> 1.7.4.1
>

--
balbi

Attachment: signature.asc
Description: Digital signature