Re: [PATCH 04/11] PINCTRL: lantiq: add output pinconf parameter

[John Crispin]

On 05/02/13 15:46, Linus Walleij wrote:
> On Fri, Feb 1, 2013 at 1:04 PM, John Crispin<blogic@xxxxxxxxxxx>  wrote:
>
> > While converting the boards inside OpenWrt to OF I noticed that the we are
> > missing a pinconf parameter to set a pin to output.
> >
> > Signed-off-by: John Crispin<blogic@xxxxxxxxxxx>
> OK, I have applied this, BUT:
>
> > @@ -34,6 +34,7 @@ enum ltq_pinconf_param {
> >          LTQ_PINCONF_PARAM_OPEN_DRAIN,
> >          LTQ_PINCONF_PARAM_DRIVE_CURRENT,
> >          LTQ_PINCONF_PARAM_SLEW_RATE,
> > +       LTQ_PINCONF_PARAM_OUTPUT,
> >   };
> All of this exist in the generic pinconf library nowadays.
>
> How about cooking a patch that converts the lantiq driver
> to just use that? It'll be pretty straight forward I think.
>
> I mean you convert it to use the generic pinconf internally,
> the DT representation we'll have to live with.
>
> See for example the new drivers that are boiling in
> -next. All use generic pinconf I think. The parameter to
> set a pin as output was added for the abx500 driver
> this cycle.
>
> Yours,
> Linus Walleij

Hi,

i'll look into updating the driver to the new api

    John
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/