Re: [PATCH 0/1] VM Sockets for Linux upstreaming

From: Andy King
Date: Tue Feb 05 2013 - 12:02:48 EST


Hi Gerd,

> Some separation still needs to be done:
>
> CC [M] net/vmw_vsock/af_vsock.o
> In file included from
> /home/kraxel/projects/linux/net/vmw_vsock/af_vsock.c:102:0:
> /home/kraxel/projects/linux/net/vmw_vsock/af_vsock.h:21:33: fatal
> error:
> linux/vmw_vmci_defs.h: No such file or directory
> compilation terminated.
> make[4]: *** [net/vmw_vsock/af_vsock.o] Error 1

Oops, you're right, it really shouldn't need that header. Sorry
about that, let me rip that out.

> Module deps are a bit bogous too:
>
> vmw_vsock_vmci_transport 26162 0
> vsock 34481 1 vmw_vsock_vmci_transport
> vmw_vmci 61602 2 vsock,vmw_vsock_vmci_transport
>
> Only vmw_vsock_vmci_transport should have a vmw_vmci dependency, not
> vsock ...

Agreed, that's not right, I'll fix that too.

> Nevertheless this should be good enough to start hacking up a virtio
> prototype.

Great!

Thanks!
- Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/