Re: [PATCH 6/9] mm/page_alloc: add informative debugging messagein page_outside_zone_boundaries()

[Cody P Schafer]

On 02/01/2013 04:29 PM, Andrew Morton wrote:
> On Fri, 1 Feb 2013 16:28:48 -0800
> Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> > > +	if (ret)
> > > +		pr_debug("page %lu outside zone [ %lu - %lu ]\n",
> > > +			pfn, start_pfn, start_pfn + sp);
> > > +
> > >   	return ret;
> > >   }
> >
> > As this condition leads to a VM_BUG_ON(), "pr_debug" seems rather wimpy
> > and I doubt if we need to be concerned about flooding the console.
> >
> > I'll switch it to pr_err.
>
> otoh, as nobody has ever hit that VM_BUG_ON() (yes?), do we really need
> the patch?

I've hit this bug while developing some code that moves pages between zones.

As it helped me debug that issue with my own code, I could see how 
another developer might be helped by it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/