Re: [PATCH 3/5] ARM: OMAP2: MUSB: Specify omap4 has mailbox

From: Russell King - ARM Linux
Date: Wed Feb 06 2013 - 05:59:05 EST


On Wed, Feb 06, 2013 at 11:28:11AM +0530, Kishon Vijay Abraham I wrote:
> Added has_mailbox to the musb platform data to specify that omap uses
> an external mailbox (in control module) to communicate with the musb
> core during device connect and disconnect.

So, I've been through your five patches looking for any other users of
"has_mailbox" and I can find none. You introduce this in this patch,
and you set it. But I don't see anything that uses it.

Write only variables are not useful.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/