Re: [PATCH 03/14] mfd: ab8500: ensure new AB8500 pinctrl driver isprobed correctly

From: Stephen Warren
Date: Wed Feb 06 2013 - 19:09:04 EST


On 02/05/2013 12:48 PM, Linus Walleij wrote:
> From: Lee Jones <lee.jones@xxxxxxxxxx>
>
> The old, BROKEN AB8500 GPIO driver has been revamped as a shiny
> new pinctrl driver and has been renamed as such. So, if we would
> like to make use of it, we need to register it via its new name.

> diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c

> static struct mfd_cell ab8500_devs[] = {
> {
> - .name = "ab8500-gpio",
> + .name = "pinctrl-ab8500",
> .of_compatible = "stericsson,ab8500-gpio",
> },

I assume that the GPIO/pinctrl driver has already been renamed in some
unrelated patch, so this patch is just fixing it so it works again?

If I'm not understanding correctly, doesn't this patch break "git
bisect", since it's only renaming it in the MFD core and not in the
driver that this expects to instantiate?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/