Re: [PATCH] rtc: max8997: Add driver for max8997 rtc.

From: jonghwa3 . lee
Date: Wed Feb 06 2013 - 22:38:14 EST


On 2013ë 02ì 07ì 11:28, Andrew Morton wrote:
> On Thu, 07 Feb 2013 10:43:23 +0900 jonghwa3.lee@xxxxxxxxxxx wrote:
>
>>> The best way of handling this sort of thing is for the driver to probe
>>> the hardware, work out its capabilities and "do the right thing".
>>>
>>> The second best way is to require that the user add certain module
>>> parameters to enable the functionality.
>>>
>>
>> How do we create sysfs node for enabling these options?
>
> I suggest using module_param[_named](), so users can execute "modprobe
> max8997 wtsr=1". Or, if the driver is built into vmlinux, add
> "max8997.wtsr=1" to the kernel boot command line.
>
> Documentation/kernel-parameters.txt mentions this.
>
Sorry, my question was incorrect, I meant to suggest to create sysfs node not to
ask you to let me know how to implement sysfs node. Anyway I'll apply your
comment and re-patch it soon.

Thanks,
Jonghwa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/