Re: [PATCH 2/3] ALSA: hda - update documentation for no-primary-hp fixup

[Takashi Iwai]

At Tue, 12 Feb 2013 16:49:46 +0900,
Fernando Luis VÃzquez Cao wrote:
> 
> The problem addressed by this fixup is not specific to Vaio Z, affecting
> some Vaio all-in-one desktop PCs too. Update the code comments accordingly.
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Cc: alsa-devel@xxxxxxxxxxxxxxxx
> Signed-off-by: Fernando Luis Vazquez Cao <fernando@xxxxxxxxxxxxx>

I applied this now to sound git tree but dropped Cc to stable because
the patch is no longer cleanly applicable due to the recent code
change.  And this is just some minor documentation update, thus we can
still live peacefully without this fix.


thanks,

Takashi

> ---
> 
> diff -urNp linux-3.7.6-orig/Documentation/sound/alsa/HD-Audio-Models.txt linux-3.7.6/Documentation/sound/alsa/HD-Audio-Models.txt
> --- linux-3.7.6-orig/Documentation/sound/alsa/HD-Audio-Models.txt	2012-12-11 12:30:57.000000000 +0900
> +++ linux-3.7.6/Documentation/sound/alsa/HD-Audio-Models.txt	2013-02-09 22:44:28.614772054 +0900
> @@ -53,7 +53,7 @@ ALC882/883/885/888/889
>    acer-aspire-8930g	Acer Aspire 8330G/6935G
>    acer-aspire		Acer Aspire others
>    inv-dmic	Inverted internal mic workaround
> -  no-primary-hp		VAIO Z workaround (for fixed speaker DAC)
> +  no-primary-hp		VAIO Z/VGC-LN51JGB workaround (for fixed speaker DAC)
>  
>  ALC861/660
>  ==========
> diff -urNp linux-3.7.6-orig/sound/pci/hda/patch_realtek.c linux-3.7.6/sound/pci/hda/patch_realtek.c
> --- linux-3.7.6-orig/sound/pci/hda/patch_realtek.c	2013-02-09 22:39:11.745202168 +0900
> +++ linux-3.7.6/sound/pci/hda/patch_realtek.c	2013-02-09 22:50:10.924470402 +0900
> @@ -5153,7 +5153,8 @@ static void alc889_fixup_imac91_vref(str
>  }
>  
>  /* Don't take HP output as primary
> - * strangely, the speaker output doesn't work on VAIO Z through DAC 0x05
> + * Strangely, the speaker output doesn't work on Vaio Z and some Vaio
> + * all-in-one desktop PCs (for example VGC-LN51JGB) through DAC 0x05
>   */
>  static void alc882_fixup_no_primary_hp(struct hda_codec *codec,
>  				       const struct alc_fixup *fix, int action)
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/