Re: [PATCH] [Watchdog][Trivial] Added comments to explainwatchdog_disabled variable
From: anish kumar
Date: Sat Feb 16 2013 - 06:39:04 EST
On Sat, 2013-02-16 at 09:42 +0100, Ingo Molnar wrote:
> * Don Zickus <dzickus@xxxxxxxxxx> wrote:
> > > >> > + /*
> > > >> > + * We shouldn't enable watchdog threads if it is
> > > >> > + * disabled.This is done by watchdog_disabled
> > > >> > + * variable check in watchdog_*_all_cpus function.
> > > >
> > > > It has two grammatic and a stylistic error in it, plus misses
> > > Would you mind pointing it out to me the grammatical mistakes
> > > as I am not that good with grammar.
> > I am not entirely sure which ones Ingo is referring to, but what I see are
> > 'disabled.This' needs a space after period
> > 'This is done by watchdog_disabled' needs a 'the' after 'by'
> > 'variable check in watchdog..' needs a 'the' after 'in'.
> > in addition to the missing ()'s after 'watchdog_*_all_cpus.
> There's also a plural/singular mismatch between 'watchdog
> threads' and 'if it is disabled'.
Thanks, I will update the same in the next patch.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/