Re: [PATCH 0/3] coredump: fix the ancient signal problems
From: Oleg Nesterov
Date: Sun Feb 17 2013 - 14:52:25 EST
On 02/17, Linus Torvalds wrote:
> On Sun, Feb 17, 2013 at 11:18 AM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> > Linus, et al, could you please ack/nack the intent? Of course I will
> > appreciate if you can review the code, but what I am actually worried
> > about is the user-visible change: the coredumping becomes killable but
> > only by the _explicit_ SIGKILL, other fatal signals are "ignored".
> That isn't a problem. In fact, we already have logic that makes the
> act of writing a file be killable by SIGKILL (because you really
> really want that for network filesystems, for example), so I suspect
> that core-dumping was interruptible by SIGKILL even before you made it
> explicitly so - simply because the IO itself was.
Yes, and even pipe_write() can fail if signal_pending() == T.
> And even if it wasn't (because maybe the SIGKILL logic doesn't get
> triggered due to all the special-case core-dumping code in signal
Yes, SIGKILL can wakeup (or can miss) the dumping thread sleeping in
->write() but this is not enough. See 2/3.
> SIGKILL really is very very special. Having it kill a
> coredump in progress sounds fine to me.
> That said, I'm not convinced about your particular split of patches.
> The first patch introduces that new SIGNAL_GROUP_COREDUMP, and then
> the second patch modifies one of the new use cases:
> - tsk->signal->flags |= SIGNAL_GROUP_COREDUMP;
> + tsk->signal->flags = SIGNAL_GROUP_COREDUMP;
> and that just smells to me like you tried too hard to split things
> into two patches.
Oh, I disagree, but I wouldn't mind to join these changes assuming
they pass the review (including my self-review tomorrow).
To me, the splitting is "natural". 1/3 protects the dumping thread
from !SIGKILL signals, 2/3 makes makes the dumping thread killable.
Another reason for 1/3 in a separate patch is the documentation,
I think we need more changes in prepare_signal(SIGNAL_GROUP_EXIT)
But I won't insist.
> I wonder if Al
> Viro hould be on the cc.
I'll send you mbox with this series privately.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/