Re: uhid: broken interface: 32/64-bit compatibility

From: Jiri Kosina
Date: Mon Feb 18 2013 - 05:28:56 EST


On Fri, 15 Feb 2013, Dmitry Torokhov wrote:

> > Here's my attempt to fix the issue.
> >
> > Not sure if tricks with padding in a good idea. We can just use __u64
> > instead of pointer, but it will require update of userspace to silence
> > cast warning and will cause warning if you will try to use updated
> > userspace with old kernel headers.
> >
> > Any comments?
>
> This does not fix anything really, we simply have to deal with compat
> interface.
>
> Compiled but not tested.
>
> Thanks.

Sorry for late response, I have been extremely busy doing some skiing :-)

Thanks a lot for fixing this embarassing bug, Dmitry. I have now applied
the patch.

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/