Re: [PATCH 1/1] VSOCK: Introduce VM Sockets
From: Gerd Hoffmann
Date: Tue Feb 19 2013 - 03:45:54 EST
On 02/18/13 18:07, Andy King wrote:
> Hi Gerd,
>>> + written = transport->stream_enqueue(
>>> + vsk, msg->msg_iov,
>>> + len - total_written);
>> Hmm, shouldn't we pass total_written to stream_enqueue here?
>> In case a blocking send(big-buffer) call gets splitted into multiple
>> stream_enqueue calls the second (and further) stream_enqueue calls need
>> to know at which msg offset they should continue sending the data, no?
> On the client side, the iov tracks it internally; see memcpy_fromiovec().
Ah, memcpy_fromiovec patches the iovec to keep track of the offset.
Wasn't aware it does this. Yes, we don't need to pass the offset then.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/