Re: [PATCH 0/4] rwsem: Implement writer lock-stealing

From: Ingo Molnar
Date: Wed Feb 20 2013 - 05:40:52 EST



* Alex Shi <alex.shi@xxxxxxxxx> wrote:

> > Alex, could you go through my patch and see if there is
> > anything you find objectionable ? (if not about the details,
> > at least about the general approach of enabling writer lock
> > stealing on the fast path)
>
> I did a quick review on the patchset and tested the patches
> 1~3, and 1~3 plus 4th, my patch plus 4th.
>
> The patch looks much complicated, and also goes writing slow
> path to steal locking. My patch looks quite straight and
> simple.
>
> This 1~3 patch has very very similar performance effect with
> mine.
>
> The highlight patch is the 4th, seems it can provide about ~2%
> aim7 performance gain(base on both of mine or patches 1~3) on
> my 4S NHM EX machine.

That speedup would be nice to have.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/