Re: [PATCH] leds-ot200: Fix misbehavior caused by wrong bit masks
From: Christian Gmeiner
Date: Sat Feb 23 2013 - 04:21:36 EST
2013/2/15 Bryan Wu <cooloney@xxxxxxxxx>:
> On Wed, Feb 13, 2013 at 7:58 AM, Christian Gmeiner
> <christian.gmeiner@xxxxxxxxx> wrote:
>> During the development of this driver an in-house register
>> documentation was used. The last weeks some integration tests
>> were done and this problem was found. It turned out that
>> the released register documentation is wrong.
>> The fix is very simple: shift all masks by one.
>> Our customers can control LEDs from userspace via Java,
>> C++ or what every. They have running/working applications where
>> they want to control led_3 but led_2 get's used.
>> I got a bug report in our in-house bug tracker so it would be
>> great to fix this upstream.
>> Signed-off-by: Christian Gmeiner <christian.gmeiner@xxxxxxxxx>
> Thanks, Christian.
> And Andrew, are you going to take care of this patch? Or I will merge this.
Whats the current state of the patch? Hope we can get it into 3.9 :)
Christian Gmeiner, MSc
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/