Re: [v3 0/6] ARM: tegra: convert device tree files to use CLK defines
From: Stephen Warren
Date: Sat Feb 23 2013 - 18:53:05 EST
On 02/23/2013 12:51 PM, Rob Landley wrote:
> On 02/19/2013 11:10:16 AM, Stephen Warren wrote:
>> On 02/17/2013 03:05 PM, Rob Landley wrote:
>> > On 02/15/2013 02:43:11 AM, Hiroshi Doyu wrote:
>> >> Hi,
>> >> With new dtc+cpp feature, we could get rid of magic numbers in dts*
>> >> files. This patch replaces CLK IDs.
>> >> We also plan to share those DT header files with kernel source
>> >> later.
>> > ...
>> >> 
>> > This really smells like documentation should be updated, probably
>> > booting-without-of.txt or similar. Alas, I'm not capable of writing
>> > an update...
>> I'm not sure what documentation would be updated nor why. Can you
>> describe that?
> "When writing new device tree files, please do not include magic
> numbers. Here's how to avoid them."
> Does something in Documentation already say this somewhere?
This seems rather basic and not worth documenting. The technique is
identical to the use of header files in C/assembly/... code. I suppose
if we document that, then there would be an argument for documenting this.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/