Re: [RFE PATCH 1/2] x86, rtc, ntp, Do full rtc synchronization withntp
From: Prarit Bhargava
Date: Sun Feb 24 2013 - 12:13:38 EST
On 02/22/2013 03:42 PM, John Stultz wrote:
> This looks reasonable to me.
> Though I want to make sure we get this thoroughly tested by the various distros
> so we don't surprise anyone, since it has to potential to cause problems where
> folks are dualbooting windows (using a localtime RTC) and do not have their OS
> setup to trigger warp_clock to adjust for the localtime rtc (instead getting a
> time correction later via NTP).
> I'll queue it and see about getting it merged to -tip & -next. Then we'll have
> to decide if 3.10 or 3.11 is the right time frame to land it.
cc'ing Alessandro as well.
John, I've been testing this across various systems (including those known to
have some wonkiness with the RTC in BIOS ... see comment below) to see if this
code impacts anything.
I've tested mainly using Fedora 18 (with the latest kernel -tip obviously), but
I also installed Ubuntu on a system to see if there was any noticeable impact
there too. I have not seen any unusual testing failures on AMD or Intel systems.
On the one system which I know to have "weak" battery such that the RTC doesn't
"stick" on the system shutdown the clock resets itself in BIOS reboot to "Jan 1
1970". When I tested previously I could not get the RTC written to the current
date; after my changes, the RTC does at least reflect the current date through a
reboot. It should be noted that if I do replace the battery on this system I
can get the RTC to properly "stick" through a reboot.
Given the test results I think this should go in earlier rather than later; I'd
like to target 3.10 for the full sync, and possibly 3.11 for the HCTOSYS stuff.
... unless anyone has a strenuous objection ;)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/