Re: [PATCH 1/2] perf annotate: Fix build with NO_NEWT=1
From: Namhyung Kim
Date: Tue Feb 26 2013 - 21:31:47 EST
Hi li guang,
On Wed, 27 Feb 2013 09:14:28 +0800, li guang wrote:
> å 2013-02-26äç 18:02 +0900ïNamhyung Kimåéï
>> Hi Michael,
>> On Tue, 26 Feb 2013 16:02:02 +1100, Michael Ellerman wrote:
>> > Commit 18c9e5c "Make it to be able to skip unannotatable symbols" broke
>> > the build with NO_NEWT=1:
>> > CC builtin-annotate.o
>> > builtin-annotate.c: In function 'hists__find_annotations':
>> > builtin-annotate.c:161:4: error: duplicate case value
>> > builtin-annotate.c:154:4: error: previously used here
>> > make: *** [builtin-annotate.o] Error 1
>> > This is because without NEWT support K_LEFT is #defined to -1 in
>> > utils/hist.h
>> > Fix it by shifting the K_LEFT/K_RIGHT #defines out of the likely range
>> > of error values.
>> Argh, didn't check NO_NEWT build on this, sorry.
>> The hist_entry__tui_annotate() - hence, symbol__tui_annotate() - returns
>> either key code or error code. This is not good IMHO but not sure it's
>> worth refactoring. Maybe we can move the error check to under default
>> case so that possible future error checks to be done?
> or can we skip gui-code-snippet when there's no gui library?
> anyway, for present fix-up, we can just temporarily change K_LEFT value
> like Michael's or my patch, I think.
That part of code won't be run on NO_NEWT build since the 'use_browser'
would be value of 0. It's just a compilation problem.
Anyway, I have no objection from the both of patches for now.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/