Re: [PATCH 2/3] cgroup: add cgroup_name() API
From: Li Zefan
Date: Wed Feb 27 2013 - 05:50:42 EST
On 2013/2/26 21:26, Tejun Heo wrote:
> On Tue, Feb 26, 2013 at 2:25 AM, Li Zefan <lizefan@xxxxxxxxxx> wrote:
>> Sure we can. We'll have to allocate cgrp->name in cgroup_remount() and
>> cgroup_init(), and free cgrp->name in cgroup_kill_sb(). It looks to me
>> the current version is a bit simpler.
> Can't we just set it to constant "/"? Root cgroup init is a separate
> path anyway.
Well, cgrp->name is a pointer to struct cgroup_name.
At first I tried to declare cgrp->name as char *, and use container_of()
to get struct cgroup_name, but it didn't result in simpler code.
So seems there's no way that is a pure win over another.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/