Re: [PATCH 9/9] remove /proc/sys/vm/hugepages_treat_as_movable

From: Naoya Horiguchi
Date: Thu Feb 28 2013 - 13:17:20 EST


On Thu, Feb 28, 2013 at 01:02:37AM -0500, KOSAKI Motohiro wrote:
> > - {
> > - .procname = "hugepages_treat_as_movable",
> > - .data = &hugepages_treat_as_movable,
> > - .maxlen = sizeof(int),
> > - .mode = 0644,
> > - .proc_handler = hugetlb_treat_movable_handler,
> > - },
>
> Sorry, no.
>
> This is too aggressive remove. Imagine, a lot of shell script don't
> have any error check.

Sure, it could break usespace applications.

> I suggest to keep this file but change to nop (to output warning is better).
> About 1-2 years after, we can remove this file safely.

OK, so I'll leave it for a while with the comment saying that this
parameter is obsolete and shouldn't be used.

Thanks,
Naoya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/