Re: [tip:core/locking] x86/smp: Move waiting on contended ticket lockout of line
From: Linus Torvalds
Date: Thu Feb 28 2013 - 18:09:23 EST
On Thu, Feb 28, 2013 at 2:38 PM, Rik van Riel <riel@xxxxxxxxxx> wrote:
> I could see doing the permission checks under a seq lock.
> If the permissions, or any other aspect of the semaphore
> array changed while we were doing our permission check,
> we can simply jump back to the top of the function and
> try again.
We do the normal file permissions under just the RCU read lock. If
it's good enough for files, them ipc semaphores certainly don't need
> The ugliness of using two kinds of protection may be
> necessary, since permissions can be modified in-place,
> and RCU does not seem to do in-place modification...
The selinux AVC code does its stuff by rcu, and for files we don't
even care if there is some uid/gid change going on - we'll get one or
the other, and live with it. There is no atomic way to change the uid
and gid anyway, so there are no new races. You get old or you get new,
or a mix of the two, any of it is "correct".
So I almost think that *everything* there in the semaphore code could
be done under RCU. The actual spinlock doesn't seem to much matter, at
least for semaphores. The semaphore values themselves seem to be
protected by the atomic operations, but I might be wrong about that, I
didn't even check. I just looked at the ipcperm() part, which
certainly doesn't seem to merit spinlocks.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/