Re: [RFC/RFT][PATCH 1/3] regulator: core: Add enable_pulldown flagto indicate pulldown on EN input

[Mark Brown]

On Fri, Feb 15, 2013 at 05:19:21PM +0800, Axel Lin wrote:
> Add enable_pulldown flag to indicate pulldown on EN input when using
> regulator_enable_regmap and friends APIs.

> -	return (val & rdev->desc->enable_mask) != 0;
> +	if (rdev->desc->enable_pulldown)
> +		return (val & rdev->desc->enable_mask) == 0;
> +	else
> +		return (val & rdev->desc->enable_mask) != 0;

Pulldown isn't the word here...  it's saying that enable is inverted,
not that it's pulled down.  Pulling something down is more an electrical
engineering thing saying what the default value for a signal is if it's
not otherwise driven, it doesn't really make sense in terms of a
register value.

Something like enable_active_low or enable_invert?

Attachment: signature.asc
Description: Digital signature