Re: [PATCH v4 1/2] i2c-core: dt: Pick i2c bus number from i2c aliasif present

From: Wolfram Sang
Date: Fri Mar 01 2013 - 14:22:22 EST


On Fri, Mar 01, 2013 at 08:57:31AM -0800, Doug Anderson wrote:
> This allows you to get the equivalent functionality of
> i2c_add_numbered_adapter() with all data in the device tree and no
> special case code in your driver. This is a common device tree
> technique.
>
> For quick reference, the FDT syntax for using an alias to provide an
> ID looks like:
> aliases {
> i2c0 = &i2c_0;
> i2c1 = &i2c_1;
> };
>
> Signed-off-by: Doug Anderson <dianders@xxxxxxxxxxxx>

Thanks, applied. I'll try to get it into 3.9.

> + /* Handled by wrappers */
> + if (WARN_ON(adap->nr == -1))
> + return -EINVAL;

I removed this check, though. We know our callers, all static.

Thanks,

Wolfram

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/