Re: [PATCH v3] gpio: Add device driver for GRGPIO cores and support custom accessors with gpio-generic

From: Grant Likely
Date: Sun Mar 03 2013 - 07:08:51 EST


On Fri, 1 Mar 2013 01:24:01 +0100, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Tue, Feb 12, 2013 at 8:24 AM, Andreas Larsson <andreas@xxxxxxxxxxx> wrote:
>
> > This driver supports GRGPIO gpio cores available in the GRLIB VHDL IP
> > core library from Aeroflex Gaisler.
> >
> > This also adds support to gpio-generic for using custom accessor
> > functions. The grgpio driver uses this to use ioread32be and iowrite32be
> > for big endian register accesses.
> >
> > Signed-off-by: Andreas Larsson <andreas@xxxxxxxxxxx>
>
> Can you split this in two patches: one that adds the custom accessors
> and one that adds the driver?

Yes please, and as commented on in the other thread you can go ahead and
add the BE accessors to gpio-generic.c. I would like to optimize things
in gpiolib to make a lot of gpio-generic.c unnecessary, but that is only
an idea at this point.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/