Re: [PATCH][v3] xhci: correctly enable interrupts

[Alan Stern]

On Mon, 4 Mar 2013, Sergei Shtylyov wrote:

> > @@ -371,6 +371,7 @@ static int xhci_try_enable_msi(struct usb_hcd *hcd)
> >   		return -EINVAL;
> >   	}
> >
> > + legacy_irq:
> >    
> 
>     Labels shouldn't be indented by a space (unless the existing coding 
> style has them indented already, of course).
> Although that might be a rule dropped by checkpatch.pl already -- it 
> doesn't complain.

Indeed, there's a definite advantage to putting a space before a label:  
The diff program doesn't get confused into thinking the label is the
start of a new function.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/