Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

From: Paul Taysom
Date: Mon Mar 04 2013 - 16:24:17 EST


On Mon, Mar 4, 2013 at 9:42 AM, Alasdair G Kergon <agk@xxxxxxxxxx> wrote:
> On Mon, Mar 04, 2013 at 08:45:48AM -0800, Paul Taysom wrote:
>> @@ -449,8 +468,14 @@ static void verity_prefetch_io(struct dm_verity *v, struct dm_verity_io *io)
>> hash_block_end = v->hash_blocks - 1;
>> }
>> no_prefetch_cluster:
>> - dm_bufio_prefetch(v->bufio, hash_block_start,
>> - hash_block_end - hash_block_start + 1);
>> + vw = kmalloc(sizeof(*vw), GFP_KERNEL);
>
> kmalloc? mempool? ...
>
> Alasdair
>
The use of mempool would be a separate patch that would have to be
measured for performance impact.
-Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/