Re: [PATCH 2/2] lglock: update lockdep annotations to reportrecursive local locks

From: Oleg Nesterov
Date: Tue Mar 05 2013 - 12:44:10 EST


On 03/04, Michel Lespinasse wrote:
>
> Both issues are easily fixed by indicating to lockdep that lglock's local
> locks are not recursive. We shouldn't use the rwlock acquire/release
> functions here, as lglock doesn't share the same semantics. Instead
> we can base our lockdep annotations on the lock_acquire_shared
> (for local lglock) and lock_acquire_exclusive (for global lglock)
> helpers.

IOW, with this patch lglock looks like rw_semaphore for lockdep...

Again, I can't ack this change, but afaics it is fine.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/