Re: [PATCH] tty/8250_pnp: serial port detection regression since v3.7

From: Vincent Deffontaines
Date: Wed Mar 06 2013 - 09:50:40 EST


Le 2013-03-04 14:28, Sean Young a ÃcritÂ:
Greg,

On Fri, Feb 22, 2013 at 04:27:19PM +0000, Sean Young wrote:
The InsydeH2O BIOS (version dated 09/12/2011) has the following in
its pnp resouces for its serial ports:

$ cat /sys/bus/pnp/devices/00:0b/resources
state = active
io disabled
irq disabled

We do not check if the resources are disabled, and create a bogus
ttyS* device. Since commit 835d844d1a28e (8250_pnp: do pnp probe
before legacy probe) we get a bogus ttyS0, which prevents the legacy
probe from detecting it.

Would you mind accepting this patch please -- it fixes a regression I
introduced in 3.7.


Hi Sean,

Thanks for the patch, and thanks for re-pushing it :)
This is to inform you that the BIOS update referenced :
Version: SC24 BIOS V1.01
Release Date: 01/11/2013

Seems to fix "my" tty detection problem on 3.7 (tested on a 3.7.6 Fedora kernel, with success).
I don't think the patch will hurt anyway - I believe it still will prevent other users from a regression.
I also confirm that the patched 3.8.0 detects its ttys fine on a BIOS-updated system.

Regards,

Vincent


--
Stop chasing shadows, just enjoy the ride
Morcheeba

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/