Re: [PATCH] gpio: gpio-ich: fix ichx_gpio_check_available() returnwhat callers expect

[Linus Walleij]

Hi Mika,

On Wed, Feb 27, 2013 at 4:25 PM, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:

> -static int ichx_gpio_check_available(struct gpio_chip *gpio, unsigned nr)
> +static bool ichx_gpio_check_available(struct gpio_chip *gpio, unsigned nr)
>  {
> -       return (ichx_priv.use_gpio & (1 << (nr / 32))) ? 0 : -ENXIO;
> +       return ichx_priv.use_gpio & (1 << (nr / 32));
>  }

Strictly speaking what you're returning there is not a bool.
Shouldn't it be:

return !!(ichx_priv.use_gpio & (1 << (nr / 32)));

?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/