Re: [PATCH 2/2] PCI: fix system hang issue of Marvell SATA host controller

[Bjorn Helgaas]

On Thu, Mar 7, 2013 at 7:29 AM,  <yxlraid@xxxxxxxxx> wrote:
> From: Xiangliang Yu <yuxiangl@xxxxxxxxxxx>
>
> Fix system hang issue: if first accessed resource file of BAR0 ~
> BAR4, system will hang after executing lspci command

This needs more explanation.  We've already read the BARs by the time
header quirks are run, so apparently it's not just the mere act of
accessing a BAR that causes a hang.

We need to know exactly what's going on here.  For example, do BARs
0-4 exist?  Does the device decode accesses to the regions described
by the BARs?  The PCI core has to know what resources the device uses,
so if the device decodes accesses, we can't just throw away the
start/end information.

> ---
>  drivers/pci/quirks.c |   15 +++++++++++++++
>  1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 0369fb6..d49f8dc 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -44,6 +44,21 @@ static void quirk_mmio_always_on(struct pci_dev *dev)
>  DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_ANY_ID, PCI_ANY_ID,
>                                 PCI_CLASS_BRIDGE_HOST, 8, quirk_mmio_always_on);
>
> +/* The BAR0 ~ BAR4 of Marvell 9125 device can't be accessed
> +*  by IO resource file, and need to skip the files
> +*/
> +static void quirk_marvell_mask_bar(struct pci_dev *dev)
> +{
> +       int i;
> +
> +       for (i = 0; i < 5; i++)
> +               if (dev->resource[i].start)
> +                       dev->resource[i].start =
> +                               dev->resource[i].end = 0;
> +}
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MARVELL_EXT, 0x9125,
> +                               quirk_marvell_mask_bar);
> +
>  /* The Mellanox Tavor device gives false positive parity errors
>   * Mark this device with a broken_parity_status, to allow
>   * PCI scanning code to "skip" this now blacklisted device.
> --
> 1.7.5.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/