Re: [PATCH] Kprobes blacklist: Conditionally add x86-specific symbols

[oskar.andero]

On 07:03 Fri 08 Mar     , Ananth N Mavinakayanahalli wrote:
> On Fri, Mar 08, 2013 at 01:23:25PM +0900, Masami Hiramatsu wrote:
> > (2013/03/07 19:44), oskar.andero@xxxxxxxxxxxxxx wrote:
> > > From: Bjorn Davidsson <bjorn.davidsson@xxxxxxxxxxxxxx>
> > > 
> > > The kprobes blacklist contains x86-specific symbols.
> > > Looking for these in kallsyms takes unnecessary time
> > > during startup on non-X86 platform.
> > > Added #ifdef CONFIG_X86 around them.
> > 
> > Right. however, it might be better break that into
> > common and arch-specific lists, because there may be
> > other arch-specific non-probe-able functions on each
> > architecture...
> 
> Agreed. CONFIG_<arch> in kernel/* is not the right thing to do IMO.
> 
> You are moving the blacklist initialization to later in the next patch,
> so how much overhead will it then be?

Well, it's not crucial for the boot time, but it is still a small
optimization.

-Oskar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/